Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly builds and release profile of ShardingSphere Proxy Native #23957

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix nightly builds and release profile of ShardingSphere Proxy Native #23957

merged 1 commit into from
Feb 13, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Feb 3, 2023 •
edited
Loading

For #23873 and #21347.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

Codecov Report

Merging #23957 (1f8c70a) into master (88d04ad) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #23957      +/-   ##
============================================
- Coverage     50.03%   50.03%   -0.01%     
  Complexity     1564     1564              
============================================
  Files          3234     3234              
  Lines         53265    53266       +1     
  Branches       9791     9794       +3     
============================================
  Hits          26649    26649              
- Misses        24272    24273       +1     
  Partials       2344     2344
Impacted Files Coverage Δ
...til/groovy/expr/HotspotInlineExpressionParser.java 94.44% <ø> (ø)
...nfra/util/expr/EspressoInlineExpressionParser.java 0.00% <0.00%> (ø)
...ore/metadata/node/PipelineMetaDataNodeWatcher.java 0.00% <0.00%> (ø)
...sor/MigrationChangedJobConfigurationProcessor.java 0.00% <0.00%> (ø)
...sistencyCheckChangedJobConfigurationProcessor.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian mentioned this pull request Feb 3, 2023
Closed
7 tasks
@linghengqian linghengqian marked this pull request as ready for review February 3, 2023 07:52
@linghengqian linghengqian force-pushed the fix-nightly-build branch 2 times, most recently from d28b37e to 71ce2f2 Compare February 3, 2023 11:02
@linghengqian
Copy link
Member Author

linghengqian commented Feb 3, 2023 •
edited
Loading

@linghengqian linghengqian marked this pull request as draft February 3, 2023 16:50
@linghengqian
Copy link
Member Author

  • Done.

@linghengqian linghengqian force-pushed the fix-nightly-build branch 3 times, most recently from fa7d87c to e3b69c2 Compare February 4, 2023 09:55
@linghengqian linghengqian changed the title Fix nightly builds of ShardingSphere Proxy Native Fix nightly builds and release profile of ShardingSphere Proxy Native Feb 4, 2023
@linghengqian linghengqian marked this pull request as ready for review February 4, 2023 14:38
@linghengqian linghengqian mentioned this pull request Feb 4, 2023
Closed
@linghengqian linghengqian force-pushed the fix-nightly-build branch 5 times, most recently from da2735f to e069e80 Compare February 5, 2023 07:09
@linghengqian
Copy link
Member Author

@linghengqian
Copy link
Member Author

  • Since oracle/graal@4a70d11 deprecated the GRAALVM_HOME system environment variable in GraalVM CE 23.0, I made additional changes.

@terrymanu terrymanu merged commit 1772157 into apache:master Feb 13, 2023
@terrymanu terrymanu added this to the 5.3.2 milestone Feb 13, 2023
@linghengqian linghengqian deleted the fix-nightly-build branch February 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
type: build
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@linghengqian @codecov-commenter @terrymanu